Skip to content

Keep ONVIF transport test setup deterministic - #1028

Merged
matteius merged 3 commits into
mainfrom
ai-findings-autofix/33tests-unit-test_onvif_transport.c
Nov 20, 2026
Merged

matteius merged 3 commits into
mainfrom
ai-findings-autofix/33tests-unit-test_onvif_transport.c

Conversation

@matteius

@matteius matteius commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Create the curl handle before launching the redirect-server thread, so setup failures do not leave a running fixture thread. Removed generated TODO comments from the existing full-registry test; that test already uses the loopback listener and verifies no request reaches it. The focused ONVIF transport suite passes.

matteius and others added 2 commits November 19, 2026 23:07
… Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
… Autofix

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@codecov

codecov Bot commented Nov 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@matteius matteius changed the title Potential fixes for 2 code quality findings Keep ONVIF transport test setup deterministic Nov 20, 2026
@matteius
matteius marked this pull request as ready for review November 20, 2026 04:16
@matteius
matteius merged commit da2d90d into main Nov 20, 2026
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant